Re: [PATCH v2] staging: sm750fb: fix resource leaks on probe error

[Greg KH]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Mon, Oct 19, 2026 at 02:46:35PM +0300, Timofey Zakharcuk wrote:
> hi Greg,
> it was found by manual code inspection by noticing the asymmetry
> between the resources
> allocated pci probe (and freed in pci remove ) versus the cleanup
> performed in the release_fb error path:
> 
> it was verified with checkpatch.pl

That verifies style only, not anything else.

> i don't have access to the physical sm750 hardware to test on real silicon.

I will have to drop this until it can be tested on real hardware as
obviously you are changing the existing logic here.

thanks,

greg k-h