Re: [PATCH 2/4] media: qcom: camss: sm8250: do not set VFE core clock rates from CSID

[Loic Poulain]

On Fri, Oct 23, 2026 at 5:29 PM Atanas Filipov
<atanas.filipov@xxxxxxxxxxxxxxxx> wrote:
>
> The SM8250 CSID resources list clock levels for the VFE core clocks and
> for the shared VFE Lite core clock. CSID power on runs after the VFE is
> powered on and sets these clocks to their lowest level, overriding the
> rate selected by the VFE from the pixel rate and lowering the shared
> VFE Lite clock under a running VFE Lite.
>
> The VFE core clocks are set by the VFE. Drop their levels from the CSID
> resources so that CSID only enables them.
>
> Signed-off-by: Atanas Filipov <atanas.filipov@xxxxxxxxxxxxxxxx>

Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>

> ---
>  drivers/media/platform/qcom/camss/camss.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index c54185c93a8a..7fe12049b78a 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -2052,7 +2052,7 @@ static const struct camss_subdev_resources csid_res_8250[] = {
>                 .clock = { "vfe0_csid", "vfe0_cphy_rx", "vfe0", "vfe0_areg", "vfe0_ahb" },
>                 .clock_rate = { { 400000000 },
>                                 { 400000000 },
> -                               { 350000000, 475000000, 576000000, 720000000 },
> +                               { 0 },
>                                 { 100000000, 200000000, 300000000, 400000000 },
>                                 { 0 } },
>                 .reg = { "csid0" },
> @@ -2069,7 +2069,7 @@ static const struct camss_subdev_resources csid_res_8250[] = {
>                 .clock = { "vfe1_csid", "vfe1_cphy_rx", "vfe1", "vfe1_areg", "vfe1_ahb" },
>                 .clock_rate = { { 400000000 },
>                                 { 400000000 },
> -                               { 350000000, 475000000, 576000000, 720000000 },
> +                               { 0 },
>                                 { 100000000, 200000000, 300000000, 400000000 },
>                                 { 0 } },
>                 .reg = { "csid1" },
> @@ -2086,7 +2086,7 @@ static const struct camss_subdev_resources csid_res_8250[] = {
>                 .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx", "vfe_lite",  "vfe_lite_ahb" },
>                 .clock_rate = { { 400000000 },
>                                 { 400000000 },
> -                               { 400000000, 480000000 },
> +                               { 0 },
>                                 { 0 } },
>                 .reg = { "csid2" },
>                 .interrupt = { "csid2" },
> @@ -2103,7 +2103,7 @@ static const struct camss_subdev_resources csid_res_8250[] = {
>                 .clock = { "vfe_lite_csid", "vfe_lite_cphy_rx", "vfe_lite",  "vfe_lite_ahb" },
>                 .clock_rate = { { 400000000 },
>                                 { 400000000 },
> -                               { 400000000, 480000000 },
> +                               { 0 },
>                                 { 0 } },
>                 .reg = { "csid3" },
>                 .interrupt = { "csid3" },
> --
> 2.34.1
>