Re: [PATCH] staging: media: atomisp: Fix double blank line

From: Dan Carpenter

Date: Fri Oct 23 2026 - 12:17:22 EST


On Fri, Oct 23, 2026 at 05:09:55PM +0300, Daniel Baluta wrote:
> On 10/23/26 16:55, Andy Shevchenko wrote:
> > On Fri, Oct 23, 2026 at 03:31:58PM +0300, Lorena Tanase wrote:
> >> Removed blank line to ensure linux kernel coding style. Found using
> >> checkpatch.pl script.
> >
> > Cool, but is this the only problem in the driver?
>
> Not the only problem but as a first patch for a newcomer we want
> to learn the process of submitting a simple patch so we keep it simple.
>
> Then will expand to send patchseries.
>
> >
> >> Cc: Daniel Baluta <daniel.baluta@xxxxxxx>
> >
> > Please, put the Cc list after the '---' line, so it won't pollute commit
> > message.
>
> Didn't know about this rule, there are thousands of patches in the Linux kernel log
> with the Cc field added there.

It's the more modern trend. It's was never clear to me what the Cc tag
was there fore...

regards,
dan carpenter