Re: [PATCH net v3 2/2] net: nixge: wait for DMA reset before releasing buffers

[Simon Horman]

Hi Myeonghun,

On Mon, Oct 19, 2026 at 02:10:52AM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 (3) · Medium: 1 (2) · Low: 1
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The patch only partly closes the hole it describes.

I believe the issue above was covered in your response to the AI-generated
review of v1.

https://lore.kernel.org/netdev/179108725013.434549.7036380491047031962@xxxxxxxxxx/

> - [Medium] One reset timeout in nixge_stop() now disables the port for
>   good, and nothing in the driver can recover it.

And I tend to think the above is an intentional implementation trade-off.
But could you comment on it?


> - [Low] On reset timeout, nixge_stop() now returns the error from
>   ndo_stop (line 959).
> 
> Pre-existing issues:

...