Re: [PATCH] media: dm1105: fix rc_dev leak on probe error paths

From: Markus Elfring

Date: Fri Oct 23 2026 - 14:30:35 EST


> dm1105_ir_init() registers an rc_dev that must be cleaned up by
> dm1105_ir_exit(). However, in dm1105_probe() the return value of
> dm1105_ir_init() is ignored, and neither the workqueue nor the
> request_irq error path calls dm1105_ir_exit(). If IR initialization
> succeeds but a later step (create_singlethread_workqueue or
> request_irq) fails, the registered rc_dev is leaked.

How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?

See also:
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3#n145
* https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v7.3#n34


Regards,
Markus