Re: [PATCH 2/2] dt-bindings: mfd: twl4030-audio: document preferred name for external mute
From: Rob Herring (Arm)
Date: Fri Oct 23 2026 - 15:18:04 EST
On Thu, 22 Oct 2026 13:29:47 -0700, Dmitry Torokhov wrote:
> Proper names for GPIOs should use "-gpios" suffix. Now that the
> twl4030 codec driver has been converted to use GPIO descriptors in
> commit 178c169a30b0 ("ASoC: codec: twl4030: Convert to GPIO
> descriptors"), update the binding documentation to list
> "ti,hs_extmute-gpios" as the preferred property name and mark
> "ti,hs_extmute_gpio" as deprecated.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
> ---
> Documentation/devicetree/bindings/sound/ti,twl4030-audio.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/ti,twl4030-audio.yaml: properties:codec:properties:ti,hs_extmute-gpios: 'anyOf' conditional failed, one must be fixed:
'$ref' is not one of ['maxItems', 'description', 'deprecated']
hint: Only "maxItems" is required for a single entry if there are no constraints defined for the values.
Additional properties are not allowed ('$ref' was unexpected)
hint: Arrays must be described with a combination of minItems/maxItems/items
'maxItems' is not one of ['description', 'deprecated', 'const', 'enum', 'minimum', 'maximum', 'multipleOf', 'default', '$ref', 'oneOf']
1 is less than the minimum of 2
hint: Arrays must be described with a combination of minItems/maxItems/items
hint: cell array properties must define how many entries and what the entries are when there is more than one entry.
from schema $id: http://devicetree.org/meta-schemas/cell.yaml
doc reference errors (make refcheckdocs):
See https://patchwork.kernel.org/project/devicetree/patch/20261022-twl4030-extmute-v1-2-3d2dbe260df9@xxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.