Re: [PATCH net v2 2/2] net: usb: cdc_mbim: don't enable BHs in tx_fixup under netpoll

[Jakub Kicinski]

On Wed, 21 Oct 2026 09:56:19 +0200 Nicolai Buchwitz wrote:
> -	spin_lock_bh(&ctx->mtx);
> +	/* IRQs are off and BHs on under netpoll, see cdc_ncm_tx_fixup() */
> +	spin_lock_irqsave(&ctx->mtx, irqflags);
>  	skb_out = cdc_ncm_fill_tx_frame(dev, skb, sign);

Sashiko is concerned that we are now running cdc_ncm_fill_tx_frame()
with IRQs disabled, I think the suggestion to use plain spin_lock()
would work? The xmit lock shields us from recursion here.
Same for patch 1.
-- 
pw-bot: cr