Re: [PATCH net v2 07/14] net: pse-pd: do not tie a shared power domain to its creator's devres

[Carlo Szelinsky]

On Thu, 22 Oct 2026 07:13:49 +0200, Oleksij Rempel wrote:
> The power domain lifetime changes in 7 and 10-12 build on each other;
> if there is another round, folding them into fewer patches would make
> them easier to review.

Thanks for the review. For v3 I would merge 7, the power domain part of
11 and 12 into one patch. Then no commit in between still has the
supply handle problem or the leak on a failed registration that
sashiko found in 7. The kfifo part of 11 stays a small patch. The
release function is then pse_pw_d_release() from the start, with the
lockdep_assert_held() you asked for.

I would keep 10 on its own. Without pse_pi_power_off() it only moves
the free of the PI array to devres and adds the unregistering flag.
It does not touch the power domain any more.

One downside: Mark and Liam would then have to review the rdev->supply
change inside a bigger patch. If you prefer, I can keep 12 separate
for them and only merge 7 and the power domain part of 11.

Is that what you meant?

Carlo