Re: [PATCH v2] iio: adc: qcom-spmi-adc5-gen3: fix lock annotations on mutex helpers
From: Jonathan Cameron
Date: Fri Oct 23 2026 - 22:30:17 EST
On Fri, 23 Oct 2026 09:47:09 +0300
Rupesh Majhi <zoone.rupert@xxxxxxxxx> wrote:
> On Wed, Oct 21, 2026 at 08:24:33PM +0100, Jonathan Cameron wrote:
> > I haven't tried yet, but I think you said not much broke?
>
> I hadn't tried either, so I did: CONTEXT_ANALYSIS := y in every
> drivers/iio Makefile, on testing, x86_64 allmodconfig, clang 23.
> 255 warnings.
>
> 240 come from iio_device_claim_direct() and
> iio_device_try_claim_buffer_mode() lacking __cond_acquires(). The rest
> are 4 in industrialio-core.c and 11 in five drivers, none of them real
> bugs. With those annotated it builds clean.
>
> v3 would be this fix without Fixes tag, core annotations, one patch per
> driver, then enabling it for drivers/iio. Does that work for you?
Yes, though no need to necessarily do it in one go if you
prefer smaller steps. I don't mind merging fixes like this
without the global enable. Maybe can do it on a directory first?
J