Re: [PATCH net] ipv6: Add NETCONFA_FORCE_FORWARDING to netconf messages

[Hangbin Liu]

Hi Ido,
On Sun, Oct 25, 2026 at 03:11:02PM +0200, Ido Schimmel wrote:
> On Fri, Oct 23, 2026 at 12:59:18PM +0200, Gabriel Goller wrote:
> > Since force_forwarding was added, changing the sysctl sends an
> > RTM_NEWNETCONF notification of type NETCONFA_FORCE_FORWARDING, but
> > inet6_netconf_fill_devconf() never emits the attribute. Listeners only
> > receive NETCONFA_IFINDEX without the new value, and RTM_GETNETCONF
> > replies and dumps omit it as well.
> > 
> > Fixes: f24987ef6959 ("ipv6: add `force_forwarding` sysctl to enable per-interface forwarding")
> > Signed-off-by: Gabriel Goller <g.goller@xxxxxxxxxxx>
> 
> This seems to fall under the "Not a regression, not critical" category
> [1], so can wait for net-next.

One question about this rule. For "not critical" fixes, should I make that
judgment myself and post to net-next? Or should I send them to net and let
the maintainers decide whether the fix should go into net or net-next?

Thanks
Hangbin
> 
> Also, NETCONFA_FORCE_FORWARDING is not emitted when it's disabled as
> part of:
> 
> sysctl -wq net.ipv6.conf.all.forwarding=0
> 
> Is this intentional?
> 
> [1] https://lore.kernel.org/netdev/CAHk-=wiSnTE9vBZ=5_v+3EEkdazCCbBM5YABRzRHUAeRdyd4Xw@xxxxxxxxxxxxxx/