Re: [PATCH] iio: proximity: sx9360: keep the IRQ balanced across suspend and resume

From: Joshua Crofts

Date: Mon Oct 26 2026 - 06:38:52 EST


On Mon, 26 Oct 2026 15:34:47 +0530
Arnav Kapoor <kapoorarnav43@xxxxxxxxx> wrote:

> sx9360_suspend() disables the interrupt first and returns with it still
> disabled if a register access fails. Resume isn't called after a failed
> suspend, so the interrupt is never enabled again. sx9360_resume() also
> returns without enabling it on error. Without an interrupt line,
> client->irq is 0 and both callbacks act on IRQ 0, which the driver
> doesn't own.
>
> Disable the interrupt only once the device is asleep, always enable it
> in resume, and skip both when there is no interrupt.
>
> Fixes: 1cdb4c47f7f5 ("iio:proximity:sx9360: Add sx9360 support")
> Signed-off-by: Arnav Kapoor <kapoorarnav43@xxxxxxxxx>
> ---
> I'm sending the same fix for sx9310, sx9324 and sx9360 as separate
> patches, as the Fixes tags differ.

Shame you didn't send the patches as a series with a cover letter
given it's the same logical change and that it concerns the sx93xx
series.

--
Kind regards,
Joshua Crofts