Re: [PATCH v11 12/18] HID: asus: size feature reports from the HID report descriptor

[Rebecca Mara Müller]

Hi Denis,

in the cover letter you asked Paolo and me to try asus_report_len() on
the Zenbook Duo. It works there, and it covers what Paolo's v4 5/7
("Do not send feature reports larger than declared") was written for.

Setup: hid.git for-next (hid-asus.c f6aa1be09ad5, the base of your
01/18), your patches 01-12, then Paolo's v4 1-4 and 6-7, leaving out
5/7. I stopped at 12 because 16/17 change asus-wmi and asus-armoury,
which I cannot swap on this kernel. Paolo's 4/7 needed a trivial
manual fixup (include context and the enum hunk); 6/7 and 7/7 applied
cleanly. Built out-of-tree against a 7.2.6-based distribution kernel,
UX8407AA, with my userspace workaround stopped.

- Docked (USB, 0b05:1cd7), captured with usbmon while reloading the
  module and pressing the backlight key: every feature report goes to
  interface 4 as report 0x5a with wLength 16, zero-padded. That is the
  handshake SET and its GET read-back, the 0x05 function query and its
  GET, the initial brightness, and two brightness changes. All
  transfers completed with status 0. The backlight key and Fn+F
  (platform profile) work.
- Bluetooth (0b05:1cd8): the backlight key and Fn+F work, no errors
  in the log. This is where, as described in 5/7, the 64 byte writes
  used to fail with -EIO.
- After docking again: backlight and Fn+F still work, and the input
  devices keep their hid-generic names.

So from my side 5/7 can be dropped in favour of this patch, and Paolo
can rebase the remaining Zenbook Duo patches on top of it.

Tested-by: Rebecca Mara Müller <rebecca.mara@xxxxxxxxx> # UX8407AA

Thanks,
Rebecca