Re: [PATCH v1 1/1] arm64: dts: freescale: imx8mm-var-dart-sonata: Fix TPM reset polarity

[Daniel Baluta]

On 10/26/26 14:35, Stefano Radaelli wrote:
> From: Stefano Radaelli <stefano.r@xxxxxxxxxxxxx>
> 
> The reset input of the ST33KTPM on the Sonata carrier is active low,
> but its reset-gpios property is declared GPIO_ACTIVE_HIGH. This
> reverses the asserted and deasserted levels of the reset signal.
> 
> Use GPIO_ACTIVE_LOW to describe the reset polarity correctly. This
> fixes the TPM not responding on I2C and the resulting absence of
> /dev/tpm0.
> 
> Fixes: 770aba46ea0f ("arm64: dts: imx8mm-var-dart: Add support for Variscite Sonata board")
> Co-developed-by: Luan Rafael Carneiro <luan.r@xxxxxxxxxxxxx>
> Signed-off-by: Luan Rafael Carneiro <luan.r@xxxxxxxxxxxxx>
> Signed-off-by: Stefano Radaelli <stefano.r@xxxxxxxxxxxxx>


Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
> index 57d29a5c3821..2644b7c1239c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-dart-sonata.dts
> @@ -259,7 +259,7 @@ st33ktpm2xi2c: tpm@2e {
>  		compatible = "st,st33ktpm2xi2c", "tcg,tpm-tis-i2c";
>  		reg = <0x2e>;
>  		label = "tpm";
> -		reset-gpios = <&pca9534 0 GPIO_ACTIVE_HIGH>;
> +		reset-gpios = <&pca9534 0 GPIO_ACTIVE_LOW>;
>  	};
>  };
>