Re: [PATCH] selftests/ftrace: Add missing spaces after ! in probe syntax tests
From: Masami Hiramatsu (Google)
Date: Mon Oct 26 2026 - 10:14:50 EST
On Sun, 25 Oct 2026 16:50:42 +0900, Jaewon Jung <jaewon8868@xxxxxxxxx> wrote:
> Add the missing space between ! and grep. Otherwise, the shell tries
> to run !grep and reports "!grep: not found". This always skips the
> conditional checks without checking for kernel return probe argument
> support.
>
> Signed-off-by: Jaewon Jung <jaewon8868@xxxxxxxxx>
Looks good to me! Also we need followings.
Fixes: 25f00e40ce79 ("tracing/probes: Support $argN in return probe (kprobe and fprobe)")
Cc: stable@xxxxxxxxxxxxxxx
Acked-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
Shuah, can you pick this fix?
Thanks,
--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>