Re: [PATCH 1/8] Docs/admin-guide/mm/damon/start: fix grammar

[SJ Park]

On Mon, 26 Oct 2026 13:41:32 +0100 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:

> On Mon, 2026-10-26 at 22:14 +1100, Aveline Noir wrote:
> > Fix a few grammar slips in the getting-started guide, like "make DAMON
> > monitors" and a region "that has not accessed".
> > 
> > "The line of the commands" used to be "The first two lines".  With only
> > one masim line left, I make it "The first line". 
> > 
> > Signed-off-by: Aveline Noir <jm5905938@xxxxxxxxx>
> > ---
> >  Documentation/admin-guide/mm/damon/start.rst | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/Documentation/admin-guide/mm/damon/start.rst b/Documentation/admin-guide/mm/damon/start.rst
> > index d98b0eb8e771..a83fcc2265bd 100644
> > --- a/Documentation/admin-guide/mm/damon/start.rst
> > +++ b/Documentation/admin-guide/mm/damon/start.rst
> > @@ -63,7 +63,7 @@ the execution. ::
> >  
> >  The first command of the above example downloads and builds an artificial
> >  memory access generator program called ``masim``.  The second command asks DAMO
> > -to start the program via the given command and make DAMON monitors the newly
> > +to start the program via the given command and make DAMON monitor the newly
> 
> 'The second command asks ... and makes ...' Thus:
> 
> +to start the program via the given command and makes DAMON monitor the newly

My intention was saying DAMO is commanding DAMON to monitor the process.  So I
find Aveline's version is slightly better.

> 
> >  started process.  The third command retrieves the current snapshot of the
> >  monitored access pattern of the process from DAMON and shows the pattern in a
> >  human readable format.
> > @@ -71,7 +71,7 @@ human readable format.
> >  The first line of the output shows the relative access temperature (hotness) of
> >  the regions in a single row heatmap format.  Each column on the heatmap
> >  represents regions of same size on the monitored virtual address space.  The
> > -position of the column on the row and the number on the column represents the
> > +position of the column on the row and the number on the column represent the
> >  relative location and access temperature of the region.  ``[...]`` means
> >  unmapped huge regions on the virtual address spaces.  The second line shows
> >  additional information for better understanding the heatmap.
> 
> I have read the damon directory aswell but I didn't find enought to send a patch yet.
> But I found this, could you add it to your patch?
> 
> @@ -78,8 +78,8 @@ additional information for better understanding the heatmap.
>  
>  Each line of the output from the third line shows which virtual address range
>  (``addr XX size XX``) of the process is how frequently (``access XX %``)
> -accessed for how long time (``age XX``).  For example, the eleventh region of
> -~9.5 MiB size is being most frequently accessed for last 3.7 seconds.  Finally,
> +accessed for how long (``age XX``).  For example, the eleventh region of
> +~9.5 MiB size is being most frequently accessed for the last 3.7 seconds.  Finally,
>  the fourth command stops DAMON.

Looks good.  Unless Aveline objects or do this by themselves with revisioning,
I will add this change when I apply this patch to damon/next.

> 
> Rest looks good to me:
> 
> Reviewed-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>

Thank you for reviewing!


Thanks,
SJ

[...]