Re: [PATCH 08/19] rtc: ds1685: use guard

[Joshua Kinard]

On 10/19/2026 17:18, alexandre.belloni@xxxxxxxxxxx wrote:
> From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
>
> Use guard() to simplify locking
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> ---
>   drivers/rtc/rtc-ds1685.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c
> index 5fc8e36b1abf..284815e5f478 100644
> --- a/drivers/rtc/rtc-ds1685.c
> +++ b/drivers/rtc/rtc-ds1685.c
> @@ -666,7 +666,7 @@ ds1685_rtc_irq_handler(int irq, void *dev_id)
>   	if (unlikely(!rtc))
>   		return IRQ_HANDLED;
>   
> -	rtc_lock(rtc->dev);
> +	guard(rtc_ops)(rtc->dev);
>   
>   	/* Ctrlb holds the interrupt-enable bits and ctrlc the flag bits. */
>   	ctrlb = rtc->read(rtc, RTC_CTRL_B);
> @@ -711,7 +711,6 @@ ds1685_rtc_irq_handler(int irq, void *dev_id)
>   		}
>   	}
>   	rtc_update_irq(rtc->dev, num_irqs, events);
> -	rtc_unlock(rtc->dev);
>   
>   	return events ? IRQ_HANDLED : IRQ_NONE;
>   }

Looks reasonable to me.  Thanks!

Acked-by: Joshua Kinard <linux@xxxxxxxxx>