Re: [PATCH] thermal: sysfs: Fix indentation in create_s32_tzp_attr()
From: Rafael J. Wysocki (Intel)
Date: Mon Oct 26 2026 - 15:26:50 EST
On Sat, Oct 3, 2026 at 2:01 AM Thorsten Blum <blum@xxxxxxxxxx> wrote:
>
> Indent the show callback consistently with the store callback and use an
> early return if the thermal zone parameters are not available.
>
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>
> ---
> drivers/thermal/thermal_sysfs.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/thermal_sysfs.c b/drivers/thermal/thermal_sysfs.c
> index 96fe5d591a0a..47daba943a76 100644
> --- a/drivers/thermal/thermal_sysfs.c
> +++ b/drivers/thermal/thermal_sysfs.c
> @@ -287,12 +287,12 @@ sustainable_power_store(struct device *dev, struct device_attribute *devattr,
> name##_show(struct device *dev, struct device_attribute *devattr, \
> char *buf) \
> { \
> - struct thermal_zone_device *tz = to_thermal_zone(dev); \
> + struct thermal_zone_device *tz = to_thermal_zone(dev); \
> + \
> + if (!tz->tzp) \
> + return -EIO; \
> \
> - if (tz->tzp) \
> return sysfs_emit(buf, "%d\n", tz->tzp->name); \
> - else \
> - return -EIO; \
> } \
> \
> static ssize_t \
Applied as 7.4-rc material, thanks!