Re: [PATCH v7.3 0/9] Various changes

From: Namjae Jeon

Date: Mon Oct 26 2026 - 21:42:53 EST


On Tue, Oct 27, 2026 at 7:26 AM Pali Rohár <pali@xxxxxxxxxx> wrote:
>
> Rebased changes on top of the v7.3.
> No functional change, just fixed 3 oneliners from Sashiko.
> Link to previous: https://lore.kernel.org/linux-cifs/20260825230622.24617-1-pali@xxxxxxxxxx/
>
> Pali Rohár (9):
> cifs: Remove code for querying FILE_INFO_STANDARD via
> CIFSSMBQPathInfo()
> cifs: Remove cifs_backup_query_path_info() and replace it by
> cifs_query_path_info()
> cifs: Fix validation of EAs for WSL reparse points
> cifs: Validate presence of EA $LXMOD for WSL reparse points
> cifs: Check if server supports EAs before trying to set it for WSL
> cifs: Extend ->set_EA() callback to allow operate on reparse point
> cifs: Create native Window socket file compatible also with WSL
> subsystem
> cifs: Add support for parsing WSL symlinks in version 1 format
> cifs: Add support for creating WSL symlinks in version 1 format

I expected there would be 10th Patch to fix the problem below.

---------------------------------8<-----------------------------------------------------------------------
> > PATCH 8/9 comment 1 - unbound memory allocation based on symlink length
> > - this is valid, but unfortunately all the symlink parsing code would do
> > similar thing. And we have already more symlink types. Do we have some
> > limit how long could be symlink? Does it make sense to address only this
> > one issue and let all other untouched? I would rather propose to define
> > one common limit and fix this issue on all places.
> I agree that a common limit is preferable. cifs.ko already has
> REPARSE_SYM_PATH_MAX(4060) for native reparse symlinks.

Lets this for followup change.
------------------------------------------------------------------------------------------------------------

Thanks.
>
> fs/smb/client/cifsglob.h | 10 +-
> fs/smb/client/cifsproto.h | 1 +
> fs/smb/client/cifssmb.c | 43 ++++---
> fs/smb/client/fs_context.c | 11 +-
> fs/smb/client/fs_context.h | 3 +-
> fs/smb/client/inode.c | 98 +-------------
> fs/smb/client/link.c | 3 +-
> fs/smb/client/reparse.c | 257 ++++++++++++++++++++++++++++++++-----
> fs/smb/client/smb1ops.c | 11 +-
> fs/smb/client/smb1proto.h | 4 +-
> fs/smb/client/smb2ops.c | 6 +-
> fs/smb/client/xattr.c | 3 +-
> fs/smb/common/fscc.h | 5 +-
> 13 files changed, 287 insertions(+), 168 deletions(-)
>
> --
> 2.20.1
>