Re: [PATCH v1 4/5] ASoC: qcom: sc8280xp: Conditionally set S16_LE format in hw_params fixup
From: Prasad Kumpatla
Date: Tue Oct 27 2026 - 04:30:19 EST
rate->min = rate->max = 48000;
- snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S16_LE);
+ switch (cpu_dai->id) {
+ case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX:
+ case QUINARY_MI2S_RX ... QUINARY_MI2S_TX:
+ case DISPLAY_PORT_RX_0:
+ case DISPLAY_PORT_RX_1 ... DISPLAY_PORT_RX_7:
+ break;
+ default:
+ snd_mask_set_format(fmt, SNDRV_PCM_FORMAT_S16_LE);
S16_LE was originally added here for compressed playback ( https://lore.kernel.org/r/20250911154340.2798304-1-alexey.klimov@xxxxxxxxxx ).
Could you confirm that compressed playback is unaffected by skipping this constraint for the MI2S and DisplayPort backends ?
Thanks,
Prasad
+ break;
+ }
channels->min = 2;
channels->max = 2;
switch (cpu_dai->id) {