RE:(2) [PATCH v4 2/9] xfs: add a flag to convert unwritten extents without allocating blocks
From: Daejun Park
Date: Tue Oct 27 2026 - 04:31:56 EST
On Thu, Oct 22, 2026 at 02:43:50PM +0200, Pankaj Raghav wrote:
> Minor nit:
>
> The following might be more explicit here:
>
> ASSERT((flags & XFS_BMAPI_CONVERT_ONLY) ? bma.nallocs == 0 :
> bma.nallocs >= *nmap);
Thanks, that is clearer, and it holds: with XFS_BMAPI_CONVERT_ONLY the
loop stops before xfs_bmapi_allocate(), the only place that counts an
allocation. I'll use it in v5.
Daejun