Re: [PATCH v5 3/3] can: gs_usb: check can_rx_offload_add_manual() return value

From: Marc Kleine-Budde

Date: Tue Oct 27 2026 - 05:35:59 EST


On 07.09.2026 12:49:42, Ciprian Costea wrote:
> From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx>
>
> gs_make_candev() ignores the return value of can_rx_offload_add_manual().
> Once can_rx_offload's skb_irq_queue is made per-CPU, that call allocates a
> per-CPU queue and can fail with -ENOMEM, leaving offload->skb_irq_queue ==
> NULL.
>
> Check the return value and exit via the existing free_candev() on error
> path.
>
> Fixes: 24bc41b45583 ("can: gs_usb: convert to NAPI/rx-offload to avoid OoO reception")
> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx>

Added this patch to gs_usb fixes series.

Thanks,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature