Re: [PATCH 00/12] ASoC: Convert last few codecs to set_jack

[Charles Keepax]

On Mon, Oct 26, 2026 at 09:19:03PM +0100, Amadeusz Sławiński wrote:
> There were still few codecs left using old method of jack detection by
> exporting public *_mic_detect() function. Convert them to .set_jack
> callback.
> 
> First implement the wrapper around *_mic_detect, currently either none
> or just one of the arguments is used, so even if function exposes more,
> wrap it, by accepting only one. (If in the future there is usecase for
> more arguments, it can be easily added, by exposing jack setting struct,
> and passing it by data pointer.)
> 
> Then convert the boards to use standard snd_soc_component_set_jack call.
> 
> And finally remove *_mic_detect() from headers and unexport it.
> 
> Amadeusz Sławiński (12):
>   ASoC: codecs: wm8903: Implement set_jack callback
>   ASoC: codecs: wm8962: Implement set_jack callback
>   ASoC: codecs: wm8994: Implement set_jack callback
>   ASoC: tegra: tegra_wm8903: Use standard callback to set jack
>   ASoC: tegra: tegra_wm8962: Use standard callback to set jack
>   ASoC: tegra: tegra_wm8994: Use standard callback to set jack
>   ASoC: samsung: littlemill: Use standard callback to set jack
>   ASoC: samsung: midas_wm1811: Use standard callback to set jack
>   ASoC: samsung: tobermory: Use standard callback to set jack
>   ASoC: codecs: wm8903: Make wm8903_mic_detect() static
>   ASoC: codecs: wm8962: Make wm8962_mic_detect() static
>   ASoC: codecs: wm8994: Make mic detect functions static
> 
>  sound/soc/codecs/wm8903.c        | 18 +++++++++++++++---
>  sound/soc/codecs/wm8903.h        |  5 -----
>  sound/soc/codecs/wm8962.c        | 10 ++++++++--
>  sound/soc/codecs/wm8962.h        |  2 --
>  sound/soc/codecs/wm8994.c        | 30 +++++++++++++++++++++++-------
>  sound/soc/codecs/wm8994.h        |  6 ------
>  sound/soc/samsung/littlemill.c   |  6 +-----
>  sound/soc/samsung/midas_wm1811.c |  3 +--
>  sound/soc/samsung/tobermory.c    |  2 +-
>  sound/soc/tegra/tegra_wm8903.c   |  5 ++---
>  sound/soc/tegra/tegra_wm8962.c   |  4 ++--
>  sound/soc/tegra/tegra_wm8994.c   |  4 ++--
>  12 files changed, 55 insertions(+), 40 deletions(-)

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles