Re: [PATCH v14 4/6] platform/x86: redmi-wmi: Drop redmi-wmi driver

[Ilpo Järvinen]

On Mon, 26 Oct 2026, Mingyou Chen wrote:

> The redmi-wmi driver is no longer needed because its functionality
> has been superseded by the new generic bitland platform driver.
> All supported Redmi laptop models are now handled properly via the
> updated WMI interfaces in bitland-mifs-wmi.
> 
> Remove the obsolete code, Kconfig entries, and Makefile references
> to clean up the platform directory.
> 
> Signed-off-by: Mingyou Chen <qby140326@xxxxxxxxx>
> ---
>  MAINTAINERS                      |   6 --
>  drivers/platform/x86/Kconfig     |  15 +--
>  drivers/platform/x86/Makefile    |   1 -
>  drivers/platform/x86/redmi-wmi.c | 154 -------------------------------
>  4 files changed, 8 insertions(+), 168 deletions(-)
>  delete mode 100644 drivers/platform/x86/redmi-wmi.c
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 250c471e674d..8ca065eb448f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -23038,12 +23038,6 @@ S:	Maintained
>  T:	git https://github.com/pkshih/rtw.git
>  F:	drivers/net/wireless/realtek/rtw89/
>  
> -REDMIBOOK WMI DRIVERS
> -M:	Gladyshev Ilya <foxido@xxxxxxxxxx>
> -L:	platform-driver-x86@xxxxxxxxxxxxxxx
> -S:	Maintained
> -F:	drivers/platform/x86/redmi-wmi.c
> -
>  BITLAND LAPTOP DRIVER
>  M:	Mingyou Chen <qby140326@xxxxxxxxx>
>  M:	Ilya Gladyshev <ilya.gladyshev@xxxxxxxxx>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 7ee9ff3879c9..6e561359a91b 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -79,16 +79,17 @@ config XIAOMI_WMI
>  	  be called xiaomi-wmi.
>  
>  config REDMI_WMI
> -	tristate "Redmibook WMI key driver"
> +	tristate "Redmibook WMI key driver (DEPRECATED)"
>  	depends on ACPI_WMI
> +	depends on HWMON
>  	depends on INPUT
> -	select INPUT_SPARSEKMAP
> +	depends on LEDS_CLASS
> +	depends on POWER_SUPPLY
> +	select BITLAND_MIFS_WMI
> +	default BITLAND_MIFS_WMI
>  	help
> -	  Say Y here if you want support for WMI-based hotkey events on
> -	  Xiaomi Redmibook devices.
> -
> -	  To compile this driver as a module, choose M here: the module will
> -	  be called redmi-wmi.
> +	  This option is deprecated and will be removed in a future release.
> +	  Please enable CONFIG_BITLAND_MIFS_WMI directly.

Hi,

I think what you should do instead is use default REDMI_WMI if REDMI_WMI 
on BITLAND side. Though I'm not sure if that's any different from plain 
default REDMI_WMI.

(I'm not always sure of things when it comes to Kconfig, so I don't know 
if it matters to avoid what is effectively default n when REDMI_WMI=n 
with the more complex clause or not, so played safe.)

Since this is only a transitional config symbol, you should drop the help 
text so it isn't user selectable anymore.

-- 
 i.