Re: [PATCH v5 08/11] phy: qualcomm: qmp-combo: Remove VCO_DIV programming from qmp_v8_configure_dp_clocks()

[Nabige Aala]

On 10/22/2026 4:06 PM, Konrad Dybcio wrote:
> On 10/1/26 11:34 AM, Nabige Aala wrote:
> > From: Ritesh Kumar <ritesh.kumar@xxxxxxxxxxxxxxxx>
> >
> > QPHY_DP_PHY_VCO_DIV register does not participate in the
> > divider of vco_divided_clk, it can be left as it is- No impact
> >
> > Fixes: d10736db98d25 ("phy: qualcomm: qmp-combo: Add DP offsets and settings for Glymur platforms")
> > Signed-off-by: Ritesh Kumar <ritesh.kumar@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Mahadevan P <mahadevan.p@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Nabige Aala <nabige.aala@xxxxxxxxxxxxxxxx>
> > ---
> The way I read the doc, it can be left as-is on Glymur, but
> not on Hamoa

Hi Konrad,

it seems Hamoa (x1e80100) follows a different callback — 
qmp_v3_configure_dp_clocks — while Glymur uses 
qmp_v8_configure_dp_clocks. Since they were already on separate code 
paths, I believe the removal of the vco_divided_clk write should not 
affect Hamoa at all. Please correct me if I'm missing something here.

Thanks,

Nabige

> Konrad