Re: [PATCH v2 5/5] fs/resctrl: Drop unnecessary parameter from resctrl_io_alloc_parse_line()
From: Reinette Chatre
Date: Tue Oct 27 2026 - 10:42:28 EST
Hi Jinjie,
On 10/27/26 1:35 AM, Jinjie Ruan wrote:
> 在 2026/10/8 5:06, Reinette Chatre 写道:
>> resctrl_io_alloc_parse_line() parses a line written to the io_alloc_cbm file.
>> It receives both a schema and a pointer to the schema's resource. Its only
>> caller looks up the resource from the schema just to pass both.
>>
>> Passing the resource separately is redundant and allows a caller to pass a
>> resource that does not belong to the schema. parse_line(), which parses lines
>> written to the schemata file, already receives only the schema and determines
>> the resource from it.
>>
>> Pass only the schema to resctrl_io_alloc_parse_line() and have it determine
>> the resource itself, matching parse_line() and in preparation for passing
>> additional information when supporting multiple controls.
>>
>> No functional change.
>>
>> Signed-off-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>
>> Reviewed-by: Ben Horgan <ben.horgan@xxxxxxx>
...
>
> LGTM
> Reviewed-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx>
Thank you very much for reviewing this series.
Reinette