Re: [PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Qianhui Xu]

On Tue, Oct 27, 2026 at 05:58:24PM +0000, Mark Brown wrote:
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.

Changed in v2 to:

  regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC

which is the shape the regulator tree is using (e.g. "regulator:
dt-bindings: ti,lp872x: Document input supplies", "regulator:
dt-bindings: sy8827n: support standard properties").  The v1 prefix was
copied from the media-side bindings I was preparing in the same batch,
which was my mistake.

> > +WILLSEMI WL2868C CAMERA PMIC DRIVER
>
> Please keep the file sorted.

Moved.  It was sitting after "VOLTAGE AND CURRENT REGULATOR FRAMEWORK",
which is the V section, while the entry name starts with W.  It is now
between "WIIMOTE HID DRIVER" and "WILOCITY WIL6210 WIRELESS DRIVER".

> Seems a bit premature to say we've got a driver when this is just the
> binding!

Agreed, the "DRIVER" suffix is dropped: the section is now "WILLSEMI
WL2868C CAMERA PMIC".  The regulator driver is a separate patch that I
will send to this list; if a driver section is wanted at that point it
should come with that patch.

> > +M:	Qianhui Xu <xiaqinghuan@xxxxxxxxxxxxxxxx>
> > +L:	linux-media@xxxxxxxxxxxxxxx
>
> A bit odd to have linux-media, I guess that's because of the systems tis
> is usually used on?

Yes, that was the reasoning - it is a camera PMIC - but it is the wrong
list to send it to.  The device registers as a regulator and is collected
by the regulator tree, so v2 uses L: linux-kernel@xxxxxxxxxxxxxxx like the
other single-file regulator bindings (maxim,max20086.yaml,
maxim,max77838.yaml).  linux-media is dropped.

There is one more thing you may want to know about v2: Krzysztof pointed
out the v1 mail was a broken patch.  The diffstat had been typed into the
commit message, so the mail had two of them.  v2 is a real commit in a
pristine 7.3-rc7 worktree exported with git format-patch.  I have also
added the consumer information to the commit message, since "why do we
want this binding" was the other open question: it is the camera PMIC on
the Lenovo Legion Tab (TB322FC, SM8750), feeding the DVDD/AVDD/DOVDD rails
of both camera sensors.

Qianhui