Re: [PATCH v23 11/15] media: qcom: camss: tpg: Add support for v2.4.0 TPG

[Bryan O'Donoghue]

On 28/10/2026 15:20, Hangxiang Ma wrote:
> Add support for the TPG found on Kaanapali. This TPG uses hardware
> version 2.4.0, which drives test-enable and reset through the
> TPG_CTRL_CMD register at offset 0x1f4 instead of the TEST_EN bit in
> TPG_CTRL and the TPG_CLEAR register. Its output is routed into the
> CSID 1080 RX through the CSI2 TPG mux, so the CSID selects the TPG as
> the data source when a test pattern is selected.
>
> Add the TPG resources to the Kaanapali camss resources so that the TPG
> subdevices are created on this SoC.
>
> Signed-off-by: Hangxiang Ma<hangxiang.ma@xxxxxxxxxxxxxxxx>

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>