Re: [PATCH v1 01/27] drm/panthor: Ignore -EOPNOTSUPP for shader-present nvmem lookup
From: Liviu Dudau
Date: Wed Oct 28 2026 - 11:52:01 EST
On Tue, Sep 22, 2026 at 09:44:55PM +0100, Karunika Choo wrote:
> When CONFIG_NVMEM is disabled, reading the optional "shader-present"
> nvmem cell can return -EOPNOTSUPP.
>
> Treat this the same as the cell being absent so panthor can continue
> probing on platforms that do not provide shader-present fuses through
> nvmem.
>
> Fixes: c40b50c3cfbe ("drm/panthor: Implement reading shader_present from nvmem")
> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> Reviewed-by: Steven Price <steven.price@xxxxxxx>
> Signed-off-by: Karunika Choo <karunika.choo@xxxxxxx>
Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>
I will probably pick some fixes from this series and apply them regardless.
Best regards,
Liviu
> ---
> v1:
> - Picked up R-bs from Boris and Steve
> - Added Fixes tag
>
> drivers/gpu/drm/panthor/panthor_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_hw.c b/drivers/gpu/drm/panthor/panthor_hw.c
> index 7e315708ca7ca..4c96573b649a1 100644
> --- a/drivers/gpu/drm/panthor/panthor_hw.c
> +++ b/drivers/gpu/drm/panthor/panthor_hw.c
> @@ -182,7 +182,7 @@ static int overload_shader_present(struct panthor_device *ptdev)
> &contents);
> if (!ret)
> ptdev->gpu_info.shader_present = contents;
> - else if (ret == -ENOENT)
> + else if (ret == -ENOENT || ret == -EOPNOTSUPP)
> return 0;
> else
> return dev_err_probe(ptdev->base.dev, ret,
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯