Re: [PATCH v2 1/2] Docs/admin-guide/mm/damon/reclaim: improve grammar and style

[Manuel Ebner]

Hi SJ,

On Tue, 2026-10-27 at 17:06 -0700, SJ Park wrote:
> On Tue, 27 Oct 2026 20:05:04 +0100 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:
> 
> > Fix upper case. Fix tenses. Replace 'set as' with 'set to'. Add space after
> > sentence to make it double space.
> > 
> > Signed-off-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
> > CC: Aveline Noir <jm5905938@xxxxxxxxx>
> > ---
> > @ -113,8 +113,8
> > Choose as you wish.

I will refer to this below.

> > 
> > @ 20
> > should be:
> > -Free Pages Reporting [3]_ based
> > +Free pages reporting [3]_ based
> > or
> > +'*Free Pages Reporting'* [3]_ based
> > * the right kind of quoting/ kernel-doc highlighting.
> > Choose as you wish.
> > ---
> >  .../admin-guide/mm/damon/reclaim.rst          | 36 +++++++++----------
> >  1 file changed, 18 insertions(+), 18 deletions(-)
> > 
> > diff --git a/Documentation/admin-guide/mm/damon/reclaim.rst b/Documentation/admin-guide/mm/damon/reclaim.rst
> > index e4e2ffa52e..0bab2299ea 100644
> > --- a/Documentation/admin-guide/mm/damon/reclaim.rst
> > +++ b/Documentation/admin-guide/mm/damon/reclaim.rst
> [...]
> > @@ -30,12 +30,12 @@ guests could mitigate this problem.
> >  How It Works?
> >  =============
> >  
> > -DAMON_RECLAIM finds memory regions that didn't accessed for specific time
> > +DAMON_RECLAIM finds memory regions that weren't accessed for specific time
> >  duration and page out.  To avoid it consuming too much CPU for the paging out
> >  operation, a speed limit can be configured.  Under the speed limit, it pages
> > -out memory regions that didn't accessed longer time first.  System
> > +out memory regions that weren't accessed longer time first.  System
> >  administrators can also configure under what situation this scheme should
> > -automatically activated and deactivated with three memory pressure watermarks.
> > +automatically be activated and deactivated with three memory pressure watermarks.
> 
> Let's keep 80 columns limit.  Same for below.

Okay.

> [...]
> > @@ -113,10 +113,10 @@ quota_sz
> >  
> >  Limit of size of memory for the reclamation in bytes.
> >  
> > -DAMON_RECLAIM charges amount of memory which it tried to reclaim within a time
> > -window (quota_reset_interval_ms) and makes no more than this limit is tried.
> > -This can be used for limiting consumption of CPU and IO.  If this value is
> > -zero, the limit is disabled.
> > +DAMON_RECLAIM records the amount of memory which it tried to reclaim within a time
> 
> Didn't we agree to keep use "charge" ?

I thought we agreed to "records' but I sensed a misunderstanding. That's why I wrote
> > @ -113,8 +113,8
> > Choose as you wish.
above. Should i have been more explicit?

Thanks
 Manuel
> 
> Other than the above two things, looks good to me.
> 
> 
> Thanks,
> SJ
> 
> [...]