Re: [PATCH net v3 2/2] net: bcmgenet: restore the Tx coalescing setting when the rings are rebuilt

From: Simon Horman

Date: Wed Oct 28 2026 - 13:26:52 EST


On Thu, Oct 22, 2026 at 10:54:07AM +0200, Nicolai Buchwitz wrote:
> bcmgenet_set_coalesce() writes tx_max_coalesced_frames straight into
> DMA_MBUF_DONE_THRESH and keeps no copy of it, while
> bcmgenet_init_tx_ring() programs a fixed 1. An ifdown and ifup or a resume
> then puts the Tx coalescing back to one frame per interrupt.
>
> Rx keeps its value per ring and reapplies it on init. Do the same for Tx.
>
> Fixes: 2f9130709d2c ("net: bcmgenet: Implement TX coalescing control knobs")
> Signed-off-by: Nicolai Buchwitz <nb@xxxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>