Re: [PATCH 1/5] blk-iocost: move shared definitions to blk-iocost.h

[Tejun Heo]

Hello, Tao.

On Wed, Oct 28, 2026 at 10:35:30PM +0800, Tao Cui wrote:
> -static struct blkcg_policy blkcg_policy_iocost;
> -
> -/* accessors and helpers */
> -static struct ioc *rqos_to_ioc(struct rq_qos *rqos)

This isn't a pure move. The comment is dropped here.

>  }
>
> -
>  static int ioc_weight_show(struct seq_file *sf, void *v)

The blank line removal is unrelated to the move.

> +	bool				user_qos_params:1;
> +	bool				user_cost_model:1;
> +
> +};

The blank line is new, and 2/5 then replaces it.

Thanks.

--
tejun