[tip: irq/urgent] irqchip/riscv-imsic: Report successful hardware retrigger

From: tip-bot2 for Avi Weiss

Date: Wed Oct 28 2026 - 16:48:15 EST


The following commit has been merged into the irq/urgent branch of tip:

Commit-ID: a2f482407d33ebe7f12e30d6cf383ffb1c7d709d
Gitweb: https://git.kernel.org/tip/a2f482407d33ebe7f12e30d6cf383ffb1c7d709d
Author: Avi Weiss <thnkslprpt@xxxxxxxxx>
AuthorDate: Mon, 26 Oct 2026 14:26:42 +02:00
Committer: Thomas Gleixner <tglx@xxxxxxxxxx>
CommitterDate: Wed, 28 Oct 2026 21:29:36 +01:00

irqchip/riscv-imsic: Report successful hardware retrigger

imsic_irq_retrigger() writes to the IMSIC MSI register to retrigger
an interrupt, but returns 0. The IRQ core treats zero as failure and
may schedule a software resend despite the hardware retrigger.

Return 1 after the MSI write to report successful hardware
retriggering and prevent the unnecessary software resend.

Fixes: 027e125acdba ("irqchip/riscv-imsic: Add device MSI domain support for platform devices")
Signed-off-by: Avi Weiss <thnkslprpt@xxxxxxxxx>
Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxx>
Reviewed-by: Björn Töpel <bjorn@xxxxxxxxxx>
Reviewed-by: Anup Patel <anup@xxxxxxxxxxxxxx>
Cc: stable@xxxxxxxxxxxxxxx
Link: https://patch.msgid.link/20261026122641.3292904-2-thnkslprpt@xxxxxxxxx
---
drivers/irqchip/irq-riscv-imsic-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-riscv-imsic-platform.c b/drivers/irqchip/irq-riscv-imsic-platform.c
index 643c8e4..52673ff 100644
--- a/drivers/irqchip/irq-riscv-imsic-platform.c
+++ b/drivers/irqchip/irq-riscv-imsic-platform.c
@@ -61,7 +61,7 @@ static int imsic_irq_retrigger(struct irq_data *d)

local = per_cpu_ptr(imsic->global.local, vec->cpu);
writel_relaxed(vec->local_id, local->msi_va);
- return 0;
+ return 1;
}

static void imsic_irq_ack(struct irq_data *d)