Re: [PATCH v2 05/10] liveupdate: Don't WARN if tracking a retrieved file fails

[Pasha Tatashin]

On Thu, 22 Oct 2026 22:50:30 +0000, David Matlack <dmatlack@xxxxxxxxxx> wrote:
> Handle a failure to add a retrieved file to luo_preserved_files instead
> of triggering a WARN_ON(). xa_insert() can fail with -ENOMEM, and
> userspace can trigger that with LIVEUPDATE_SESSION_RETRIEVE_FD, so
> warning about it lets userspace crash systems with panic_on_warn.
> 
> The handler has already consumed the preserved state when this happens,
> so make the failure permanent. Keep the file until the file set is
> finished, like any other retrieved file, so that its resources are not
> released before then. Finishing the file set then erases the file from
> luo_preserved_files, which does nothing for a file that was never added.
> 
> [...]

Acked-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>

-- 
Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>