Re: [PATCH v2 2/2] Docs/admin-guide/mm/damon/reclaim: rewrite complex parts

[SJ Park]

On Wed, 28 Oct 2026 17:52:17 +0100 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:

> Hi SJ,
> 
> On Tue, 2026-10-27 at 17:19 -0700, SJ Park wrote:
> > Hello Manuel,
> > 
> > 
> > On Tue, 27 Oct 2026 22:23:46 +0100 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:
> > 
> > > Rewrite complex sentences.
> > 
> > Any special reason to keep this as a separated one?  I think it is ok to merge
> > this into the first patch.
> 
> In this mail ( https://lore.kernel.org/all/20261016142921.126622-1-sj@xxxxxxxxxx/ )
> > Let's do such rewriting with another patch.
> 
> I understood this as 'make it two patches'.

Thank you for reminding me the memory.  I now remember I thought it is better
to be a separate patch.  And now I realize I was wrong.  Now I think realize
this is small enough change that can be collapsed into one patch.  Sorry for
changing my words.

[...]
> > > @@ -125,8 +126,8 @@ quota_reset_interval_ms
> > >  
> > >  The time/size quota charge reset interval in milliseconds.
> > >  
> > > -The charge reset interval for the quota of time (quota_ms) and size
> > > -(quota_sz).  That is, DAMON_RECLAIM does not try reclamation for more than
> > > +The charge reset interval for the quota of time is quota_ms and for the quota of
> > > +size is quota_sz.  That is, DAMON_RECLAIM does not try reclamation for more than
> > >  quota_ms milliseconds or quota_sz bytes within quota_reset_interval_ms
> > >  milliseconds.
> > 
> > I think the original sentence was not that confusing.  Also, this changes the
> > nuance of the sentence?  What the sentence is saying is
> > "quota_reset_interval_ms is the charge reset interval for ...".  If this was
> > really confusing, maybe we can add "quota_reset_interval_ms is " part.
> > 
> > But, I start feeling we might trying too much polishing...?
> 
> I think the verb is missing or can you tell which the verb is? If you can
> no fix is required.

I mean, changing only the first sentence, like below:

"quota_reset_interval_ms is the charge reset interval for the quota of time
(quota_ms) ans size (quota_sz)."

> 
> > 
> > >  
> > > @@ -137,7 +138,7 @@ quota_mem_pressure_us
> > >  
> > >  Desired level of memory pressure-stall time in microseconds.
> > >  
> > > -While keeping the caps that are set by other quotas, DAMON_RECLAIM automatically
> > > +While respecting the limits imposed by other quotas, DAMON_RECLAIM automatically
> > >  increases and decreases the effective level of the quota aiming this level of
> > >  memory pressure is incurred.  System-wide ``some`` memory PSI in microseconds
> > >  per quota reset interval (``quota_reset_interval_ms``) is collected and
> > 
> > I'm not sure if the original sentence was really difficult to understand.
> > 
> > I'd prefer dropping this change.
> 
> That's ok.

Thank you for accepting my humble suggestion.

> 
> Will you handle the final edit or should I send a [v3]?

Could you please send v3?


Thanks,
SJ

[...]