Re: [PATCH v2 1/2] nfc: pn533: complete failed queued commands and keep queue moving

[Zhao Feng]

Hi Simon,

Thanks for the review and the Reviewed-by tags.

On the Fixes tag for patch 1/2: I traced the history as far as I can
from here.  The broken error path predates the 2013 split into
drivers/nfc/pn533/: commit 60ad07ab6bc8 ("NFC: pn533: Fix missing lock
while operating on commands list", 2012) already shows pn533_wq_cmd()
processing the queue in the original single-file driver, so the bug
goes back to the introduction of the command queue in the pre-split
drivers/nfc/pn533.c.  Unfortunately kernel.org and github are
unreachable from my current network, so I cannot verify the exact
introducing commit hash, and I would rather not guess at one.  If
someone with history access can pin it down (git log --follow on
drivers/nfc/pn533/pn533.c), I'm happy with whatever tag that yields;
otherwise leaving the tag out also seems reasonable for a bug this
old.

On the git am failure: the pn533_wq_cmd() region is byte-identical
between the tree I diffed against and current master (checked line by
line on codebrowser.dev), and the Media CI bot applied and processed
the sibling patch, generated the same way, without issues.  So I
suspect the fuzz comes from drift in the tree you applied to rather
than the patch itself.  If it still fails, let me know what it
conflicts with and I'll respin rebased against that.

Thanks,
Zhao Feng