Re: [PATCH v3 1/2] platform/chrome: cros_ec_typec: Enforce priority-based mode selection
From: Tzung-Bi Shih
Date: Thu Oct 29 2026 - 00:22:55 EST
On Wed, Oct 28, 2026 at 09:09:31AM +0000, Andrei Kuchynski wrote:
> The driver sets mode_selection bit for each Alternate mode, thereby
> preventing individual altmode drivers from activating their respective
> modes.
> Once the registration of all Alternate Modes is complete, the driver
> verifies if USB4 mode is supported by both the port and the partner and
> activates USB4 mode. In cases where USB4 is not supported, the driver
> invokes typec_mode_selection_start to initiate the mode selection process
> based on mode priorities.
> The driver communicates the current Type-C mode to the mode selection
> process via typec_altmode_state_update.
Hi Andrei,
I'm less familiar with the details of cros_ec_typec and its friend drivers.
Could you double-check the Sashiko review [1] to see if any of the findings
need to be addressed as they look real?
[1] https://sashiko.dev/#/patchset/20261028090932.27053-1-akuchynski%40chromium.org