Re: [PATCH] tty: n_tty: convert the full VTIME interval to jiffies

[Hungyu Lin]

> Ok, and has it ever reported problems with this rounding error?  This is
> very old code, changing it needs to be done only if an issue is actually
> noticed as it might be relied on, right?

I don't have a report from users of those systems. I found this by
inspection and reproduced the early timeout using PTYs under QEMU.

For comparison, FreeBSD's original VMIN/VTIME code keeps the timeout
in microseconds and rounds the remaining interval up when
converting to ticks:
https://github.com/freebsd/freebsd-src/commit/d32198f15b39a0f6dc29229ba4925d67d136956e

I understand that this doesn't rule out applications depending on the
existing Linux timing. Would you consider the conversion correction
worthwhile on that basis?

Thanks,
Hungyu