Re: [PATCH 9/9] arm64: dts: qcom: sm8750: add the camera subsystem

[Shuai Liu]

Hi Qianhui,

The node itself matches the binding from patch 1: 19 register ranges,
35 clocks, 16 interrupts, four interconnects and four power domains all
line up with qcom,sm8750-camss.yaml, so from a schema point of view
this looks right.

One nit in the commit message:

> the SM8750 block has four CSID, six CSIPHY, three VFE and
> two VFE lite instances

The node describes five CSIDs (csid0, csid1, csid2, csid_lite0,
csid_lite1), not four - three full plus two lite.  The VFE counts
(three full, two lite) are correct.  Patch 1/9 and 8/9 carry the same
miscount in their commit messages.

Minor: the node declares the camera subsystem as "isp@ad27000".  The
existing qcom camss nodes use "camss@" or "isp@" inconsistently, so
this is fine, just noting it for the record since the binding example
matches.

Thanks,
Shuai Liu

(This review was prepared with the assistance of an AI coding tool;
all findings were verified against the patched source.)