Re: [PATCH v3 02/13] ASoC: amd: acp: add ACP7.B/7.F SoundWire DAI link support

[Pierre-Louis Bossart]

On 10/29/26 05:56, Mukunda,Vijendar wrote:
> On 26/10/26 02:41, Pierre-Louis Bossart wrote:
>> It'd be useful to comment/explain why this routine only relies on a
>> subset of IDS...
> On ACP7x, each SoundWire data port has a dedicated DMA channel mapped
> in hardware. This function selects only the ports required by the
> currently supported ACP7x machine topologies:
> 
>   AUDIO0_TX (0)  - headset/jack playback
>   AUDIO4_TX (4)  - amplifier/speaker playback
>   AUDIO0_RX (11) - headset/jack capture
>   AUDIO4_RX (15) - amplifier/speaker capture (feedback)
>   AUDIO5_RX (16) - DMIC capture
> 
> The remaining port IDs are defined for completeness to represent the
> hardware data port layout, but are not used by the currently supported
> machine topologies.
> 
> The ID numbering differs from ACP70 due to the hardware differences
> between ACP70 and ACP7x. ACP7x uses a flat ID space, with TX ports
> numbered 0-10 and RX ports numbered 11-21.
> 
> Will add comments above the define block and the function to clarify
> this in the next version.
sounds good, thank you.