Re: [PATCH] sched/cache: Check reduced capacity before alb_break_llc()

[Kayra Cizmeci]

On Thu, Oct 29, 2026 at 03:50:43PM +0800, Zhan Xusheng wrote:
> Hi Kayra,
> 
> On Thu, Oct 29, 2026 at 10:13:10AM +0300, Kayra Cizmeci wrote:
> > Well yeah. alb_break_llc() just returns true in the nr_running <= 1
> > case. FWIW, on my tip tree this just creates a conflict. On me
> > alb_break_llc() is first, then asym_active_balance() and then
> > imbalanced_active_balance(). I think in that case moving all three
> > functions would be better? (below this other block that's for this case)
> 
> That's sched/core, which doesn't have ee92b7ef4c1e ("sched/cache: Honor
> asym packing over cache aware scheduling on hybrid systems") yet.  The
> patch is on top of it and applies to tip/master.
> 
> Only alb_break_llc() needs to go below the capacity check, as it is the
> only one that returns 0.  The other two only return 1, so where they
> sit relative to the capacity check doesn't matter.
> imbalanced_active_balance() moves only to stay behind alb_break_llc().

Ah, my bad :-).


Reviewed-by: Kayra Cizmeci <kayracizmeci@xxxxxxxxx>

> 
> Thanks,
> Zhan Xusheng

Thanks,

Kayra