Re: [PATCH v2 2/5] drm/bridge: cdns-mhdp8546: Use drm_dp_enhanced_frame_cap()

[Jani Nikula]

On Thu, 29 Oct 2026, Dmytro Malovanyi <dmitrymalovanyy@xxxxxxxxx> wrote:
> Use the helper instead of checking DP_ENHANCED_FRAME_CAP directly, so
> enhanced framing is used for all DPCD r1.2+ sinks as the spec requires.
>
> Compile tested only.
>
> Signed-off-by: Dmytro Malovanyi <dmitrymalovanyy@xxxxxxxxx>

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

> ---
>  drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> index f47717bd1..8cab9a3e6 100644
> --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
> @@ -1375,7 +1375,7 @@ static int cdns_mhdp_link_up(struct cdns_mhdp_device *mhdp)
>  	mhdp->link.rate = drm_dp_bw_code_to_link_rate(dpcd[1]);
>  	mhdp->link.num_lanes = dpcd[2] & DP_MAX_LANE_COUNT_MASK;
>  
> -	if (dpcd[2] & DP_ENHANCED_FRAME_CAP)
> +	if (drm_dp_enhanced_frame_cap(dpcd))
>  		mhdp->link.capabilities |= DP_LINK_CAP_ENHANCED_FRAMING;

I note that the driver should probably also switch to
drm_dp_read_dpcd_caps(), but that's beyond the patch at hand.

>  
>  	dev_dbg(mhdp->dev, "Set sink device power state via DPCD\n");

-- 
Jani Nikula, Intel