Re: [PATCH v2 3/5] drm/bridge: it6505: Use drm_dp_enhanced_frame_cap()

[Jani Nikula]

On Thu, 29 Oct 2026, Dmytro Malovanyi <dmitrymalovanyy@xxxxxxxxx> wrote:
> Use the helper instead of checking DP_ENHANCED_FRAME_CAP directly, so
> enhanced framing is used for all DPCD r1.2+ sinks as the spec requires.
>
> Compile tested only.
>
> Signed-off-by: Dmytro Malovanyi <dmitrymalovanyy@xxxxxxxxx>

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>

Here too the driver should probably use drm_dp_read_dpcd_caps(), but
again beyond the patch.

> ---
>  drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index e136ac71e..d798a3db7 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -1651,7 +1651,7 @@ static void it6505_parse_link_capabilities(struct it6505 *it6505)
>  	link->rate = drm_dp_bw_code_to_link_rate(it6505->dpcd[1]);
>  	link->num_lanes = it6505->dpcd[2] & DP_MAX_LANE_COUNT_MASK;
>  
> -	if (it6505->dpcd[2] & DP_ENHANCED_FRAME_CAP)
> +	if (drm_dp_enhanced_frame_cap(it6505->dpcd))
>  		link->capabilities = DP_ENHANCED_FRAME_CAP;
>  
>  	DRM_DEV_DEBUG_DRIVER(dev, "DPCD Rev.: %d.%d",

-- 
Jani Nikula, Intel