Re: [PATCH v3] cxl/edac: Fail ECS threshold read for reserved encodings

[Yili Zhang]

Hi Ben,

Thanks for the review, and thanks Jonathan for sorting out the
documentation question.

On 2026-10-28 09:18, Cheatham, Benjamin wrote:
> On 10/27/2026 8:16 PM, Jonathan Cameron wrote:
> > On Fri, 23 Oct 2026 16:05:27 -0500
> > "Cheatham, Benjamin" <benjamin.cheatham@xxxxxxx> wrote:
> > 
> >> On 10/21/2026 10:20 AM, Yili Zhang wrote:
> >>> cxl_get_ecs_threshold() extracts a 3-bit index (0-7) from the
> >>> device-supplied ECS config word and uses it to index  
> >>
> >> Nit: Should probably spell out ECS here for people (like myself) who don't
> >> know what it means.

Will do. v4 will spell out "Error Check Scrub (ECS)" in the first
paragraph, matching the wording in Documentation/ABI/testing/sysfs-edac-ecs.

> 
> Cool, then this looks good to me. For Yili:
> 
> Reviewed-by: Ben Cheatham <benjamin.cheatham@xxxxxxx>
> 
> And thanks for the response Jonathan!
> 
> Thanks,
> Ben
> 

v4 will also drop the Suggested-by tag, per feedback on the v2 thread.
The diff itself is unchanged, so unless anyone objects I'll carry your
Reviewed-by over to v4.

Best regards,
Yili