Re: [PATCH net v2] net: pcs: xpcs: make supported_interfaces authoritative
From: Andrew Lunn
Date: Thu Oct 29 2026 - 09:14:48 EST
> + /*
> + * The RK3568 XPCS supports 1000BASE-X, SGMII and QSGMII.
> + */
> + phy_interface_zero(xpcs->pcs.supported_interfaces);
> + __set_bit(PHY_INTERFACE_MODE_SGMII, xpcs->pcs.supported_interfaces);
The comment and the code does not really match. Why not set the other
two interface modes as well?
Andrew