Re: [PATCH 3/3] iio: proximity: Add Benewake TF-Luna LiDAR driver

[Andy Shevchenko]

On Thu, Oct 29, 2026 at 07:49:15AM +0530, Vidhu Sarwal wrote:
> On Tue, Oct 20, 2026 at 10:42:51AM +0300, Andy Shevchenko wrote:

...

> > > > +static const struct regmap_config tf_luna_regmap_config = {
> > > > +       .reg_bits = 8,
> > > > +       .val_bits = 8,
> > > > +       .max_register = TF_LUNA_REG_SIGNATURE + 3,
> >
> > No cache?
> 
> The only configuration register the driver writes to is MODE, once
> during probe. The other write is only a one shot trigger, and the
> registers read afterwards contain measurement data that keeps
> changing. also need to read MODE back from hardware since the sensor
> can silently ignore writes that come too quickly. I was planning to
> add caching later along with runtime PM to restore MODE , but I can
> add it in v2 if you think its better added now.

Just add a comment summarizing what you just said.

-- 
With Best Regards,
Andy Shevchenko