Re: [PATCH] xfs: fix out-of-bounds write from crafted btree root numrecs during log recovery
From: Jonathan Corbet
Date: Thu Oct 29 2026 - 10:43:35 EST
Dave Chinner <dgc@xxxxxxxxxx> writes:
> On Wed, Oct 28, 2026 at 04:43:37PM -0600, Jonathan Corbet wrote:
>> Dave Chinner <dgc@xxxxxxxxxx> writes:
>>
>> > Unless you know how to fix the discovered problem correctly, don't
>> > send what your LLM proposed for review. It will be garbage, and all
>> > that will do is annoy whoever has to review it. Just report the bug,
>> > let the subsystem developers fix it.
>>
>> Just to be obnoxious...this runs counter to the advice we have in
>> Documentation/process/security-bugs.rst, where reporters are requested
>> to include a proposed fix as well. It seems we're sending a bit of a
>> mixed message...
>
> These aren't security bugs. Bugs that result from maliciously
> corrupted filesystem images (i.e. fuzzed) are explicitly stated as
> not covered by the kernel security threat models. IOWs, they are
> just -bugs-, and bugs that just don't ever happen in the real world.
I wasn't arguing about the nature of the bug ... just noting the
disconnect with what I've heard from some maintainers, who say that
providing a patch helps in the identification of the problem, even if
the patch is not used.
Thanks,
jon