Re: [PATCH v4 01/31] accel: ethosu: Suspend after initialization

[Frank Li]

On Thu, Oct 29, 2026 at 08:35:48AM -0500, Rob Herring (Arm) wrote:
> The initial runtime-PM reference is held only while initializing the
> NPU. Release it synchronously from ethosu_init() after the final
> hardware access, before registering the DRM device.
>
> This keeps the runtime-PM setup and initial reference handling together
> and leaves the autosuspend configuration in place for subsequent jobs.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>

> v2:
>  - new patch
> ---
>  drivers/accel/ethosu/ethosu_drv.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/accel/ethosu/ethosu_drv.c b/drivers/accel/ethosu/ethosu_drv.c
> index 4a24bbd2bb61..38af57807cee 100644
> --- a/drivers/accel/ethosu/ethosu_drv.c
> +++ b/drivers/accel/ethosu/ethosu_drv.c
> @@ -338,6 +338,8 @@ static int ethosu_init(struct ethosu_device *ethosudev)
>  		 ethosudev->npu_info.sram_size / 1024,
>  		 ethosudev->npu_info.pmu_counters);
>
> +	pm_runtime_put_sync_suspend(ethosudev->base.dev);
> +
>  	return 0;
>  }
>
> @@ -376,10 +378,6 @@ static int ethosu_probe(struct platform_device *pdev)
>  		return ret;
>
>  	ret = drm_dev_register(&ethosudev->base, 0);
> -	if (ret)
> -		pm_runtime_dont_use_autosuspend(ethosudev->base.dev);
> -
> -	pm_runtime_put_autosuspend(ethosudev->base.dev);
>  	return ret;
>  }
>
>
> --
> 2.53.0
>