Re: [PATCH] scsi: qedf: Remove unesseary function call

From: Laurence Oberman

Date: Thu Oct 29 2026 - 12:36:47 EST


On Thu, 2026-10-29 at 12:04 -0400, Jesse Taube wrote:
> The result of `skb_transport_header` was unused. Calling this
> function
> warned when `skb_transport_header_was_set` returned false causing a
> panic on debug kernels.
>
> Signed-off-by: Jesse Taube <jtaubepe@xxxxxxxxxx>
> ---
>  drivers/scsi/qedf/qedf_main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c
> b/drivers/scsi/qedf/qedf_main.c
> index da429b3a4283..f2bc0ac684e0 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx
> *qedf,
>  
>   /* Pull the header */
>   hp = (struct fcoe_hdr *)skb->data;
> - fh = (struct fc_frame_header *) skb_transport_header(skb);
>   skb_pull(skb, sizeof(struct fcoe_hdr));
>   fr_len = skb->len - sizeof(struct fcoe_crc_eof);
>  

Looks good
Reviewed-by: Laurence Oberman <loberman@xxxxxxxxxx>