Re: [PATCH v2] powerpc: dts: Add support for WatchGuard Firebox T30

From: Rob Herring (Arm)

Date: Thu Oct 29 2026 - 13:38:40 EST



On Thu, 29 Oct 2026 07:27:41 -0400, Lefteris Koutrakis wrote:
> Add initial device tree support for the WatchGuard Firebox T30 board.
> Enable building firebox-t30.dtb under CONFIG_MPC85xx_RDB in the
> arch/powerpc/boot/dts/fsl/Makefile. Document the watchguard vendor
> prefix in vendor-prefixes.yaml.
>
> Signed-off-by: Lefteris Koutrakis <lefteris.koutrakis@xxxxxxxxx>
> ---
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> arch/powerpc/boot/dts/fsl/Makefile | 1 +
> arch/powerpc/boot/dts/fsl/firebox-t30.dts | 386 ++++++++++++++++++
> 3 files changed, 389 insertions(+)
> create mode 100644 arch/powerpc/boot/dts/fsl/firebox-t30.dts
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/vendor-prefixes.yaml:2022:1: [error] missing document start "---" (document-start)
./Documentation/devicetree/bindings/vendor-prefixes.yaml:2022:3: [error] syntax error: expected '<document start>', but found '<block mapping start>' (syntax)

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/vendor-prefixes.yaml: ignoring, error parsing file
./Documentation/devicetree/bindings/vendor-prefixes.yaml: error loading YAML: expected a single document in the stream
in "./Documentation/devicetree/bindings/vendor-prefixes.yaml", line 4, column 1
but found another document
in "./Documentation/devicetree/bindings/vendor-prefixes.yaml", line 2022, column 3
./Documentation/devicetree/bindings/vendor-prefixes.yaml:2022:3: but found another document

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20261029112742.10238-1-lefteris.koutrakis@xxxxxxxxx

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.