Re: [PATCH v2 0/2] ACPI: EC / hwmon: (asus-ec-sensors) use ec.c for the MAXIMUS IX EXTREME second EC

[Guenter Roeck]

On 10/29/26 00:48, Remy Demangeot via B4 Relay wrote:
> This replaces patch 3/3 of the series "hwmon: (asus-ec-sensors) more
> MAXIMUS IX EXTREME sensors" [1]. Patches 1/3 and 2/3 of that series
> only use the main EC and are unchanged.
>
> Eugene asked to operate the second EC through drivers/acpi/ec.c rather
> than re-implementing the EC protocol in the driver [2]. Patch 1 adds a
> small API to ec.c for an EC that is not described in the ACPI tables:
> acpi_ec_create_polled() / acpi_ec_destroy_polled() and byte accessors.
> Such an EC only uses busy polling: no GPE, no IRQ, no query events and
> no address space handler. Patch 2 uses it in asus-ec-sensors.
>
> To answer Armin's question [3]: no, this EC is not described in the
> ACPI tables of this board (BIOS 1501). There is no PNP0C09 device for
> it; only the WMI method \_SB.AMW0.WLDF writes to ports 0x68/0x6c
> directly, without taking any lock. The other PNP0C09 device, H_EC, is
> a reference-code stub whose _STA returns 0.
>
> Guenter, please drop v1 3/3: it sorted the sensor banks as signed

Dropped, but please next time provide the patch subject. I understand you
know what that was, but I already had 80 patches queued for 7.5, including
five for this driver. I dropped what I _think_ was patch 3/3, which is
the water temperature patch. If that is not what you intended, please resend
everything that is not already in the mainline kernel.

Guenter
> values, so the second EC bank came first, the second EC was never set
> up, and no sensor of the board could be read anymore. This is fixed in
> patch 2 and was found while testing this series.
>
> Both patches were tested on a MAXIMUS IX EXTREME with Secure Boot
> enabled: the four water temperatures read correctly, 300
> consecutive reads gave no error, and the I/O ports are released and
> requested again when the module is reloaded.
>
> Patch 1 needs an ack from the ACPI side; patch 2 depends on it.
>
> [1] https://lore.kernel.org/r/20261026-b4-m9e-ext-sensors-v1-0-644d389b2de1@xxxxxxxxxxxxx
> [2] https://lore.kernel.org/r/CAB95QAQaogxV6KO5kpv9RBpzhhmH_N3Dvvy=nqWHOG6qAQB_aw@xxxxxxxxxxxxxx
> [3] Armin Wolf, reply to v1 3/3, 28 Oct 2026
>
> ---
> Remy Demangeot (2):
>        ACPI: EC: allow drivers to create a polled EC
>        hwmon: (asus-ec-sensors) add water temperatures for MAXIMUS IX EXTREME
>
>   drivers/acpi/ec.c               |  89 ++++++++++++++++++++++++++++++++-
>   drivers/hwmon/asus-ec-sensors.c | 108 ++++++++++++++++++++++++++++++++++------
>   include/linux/acpi.h            |   8 +++
>   3 files changed, 189 insertions(+), 16 deletions(-)
> ---
> base-commit: b27578907b9dd74db5e9b397bf063c43719c162b
> change-id: 20261029-m9e-ec2-68fad8c08d5a
>
> Best regards,